Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resources with relationshipRef #1514

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Support resources with relationshipRef #1514

merged 4 commits into from
Apr 4, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 4, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

CloudFormation schemas have started to include relationshipRefs. Following the merge of #1513 we can now generate Terraform schemas for such CloudFormation schemas.
A few resource schemas were not being updated because of this constraint. Regenerate them.

Relates hashicorp/aws-cloudformation-resource-schema-sdk-go#54.
Relates hashicorp/aws-cloudformation-resource-schema-sdk-go#53.
Relates aws-cloudformation/cloudformation-resource-schema#151.

% GO_VER=go1.22.1 TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_' ACCTEST_PARALLELISM=3
TF_ACC=1 go1.22.1 test ./internal/aws/logs -v -count 1 -parallel 3 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m
=== RUN   TestAccAWSLogsLogGroup_basic
=== PAUSE TestAccAWSLogsLogGroup_basic
=== RUN   TestAccAWSLogsLogGroup_disappears
=== PAUSE TestAccAWSLogsLogGroup_disappears
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== RUN   TestAccAWSLogsLogGroupDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupDataSource_basic
=== RUN   TestAccAWSLogsLogGroupDataSource_NonExistent
=== PAUSE TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroup_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_basic
=== CONT  TestAccAWSLogsLogGroup_update
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (30.37s)
=== CONT  TestAccAWSLogsLogGroupDataSource_NonExistent
--- PASS: TestAccAWSLogsLogGroup_basic (30.71s)
=== CONT  TestAccAWSLogsLogGroup_disappears
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (2.38s)
--- PASS: TestAccAWSLogsLogGroup_update (42.08s)
--- PASS: TestAccAWSLogsLogGroup_disappears (36.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	68.757s

@ewbankkit ewbankkit merged commit 16665a7 into main Apr 4, 2024
11 checks passed
@ewbankkit ewbankkit deleted the f-relationshipRef branch April 4, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit